[llvm] [SPIR-V] Improve type inference: fix types of return values in call lowering (PR #116609)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 06:58:12 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 5eeb3fef61bf5542c3fdcb71622fc4e826527789 6d0c3111eeaeb99169bcac682e5e46e9750c5483 --extensions cpp,h -- llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp llvm/lib/Target/SPIRV/SPIRVPostLegalizer.cpp llvm/lib/Target/SPIRV/SPIRVUtils.cpp llvm/lib/Target/SPIRV/SPIRVUtils.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp b/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
index f67b28f1ed..c17ae65495 100644
--- a/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp
@@ -394,11 +394,11 @@ void SPIRVTargetLowering::finalizeLowering(MachineFunction &MF) const {
       case SPIRV::OpGenericCastToPtr:
         validateAccessChain(STI, MRI, GR, MI);
         break;
-//      case SPIRV::OpPtrAccessChain:
-//      case SPIRV::OpInBoundsPtrAccessChain:
-//        if (MI.getNumOperands() == 4)
-//          validateAccessChain(STI, MRI, GR, MI);
-//        break;
+        //      case SPIRV::OpPtrAccessChain:
+        //      case SPIRV::OpInBoundsPtrAccessChain:
+        //        if (MI.getNumOperands() == 4)
+        //          validateAccessChain(STI, MRI, GR, MI);
+        //        break;
 
       case SPIRV::OpFunctionCall:
         // ensure there is no mismatch between actual and expected arg types:

``````````

</details>


https://github.com/llvm/llvm-project/pull/116609


More information about the llvm-commits mailing list