[llvm] [Inliner] Don't count a call penalty for foldable __memcpy_chk and similar (PR #117876)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 27 06:50:12 PST 2024
================
@@ -2260,6 +2271,48 @@ bool CallAnalyzer::simplifyCallSite(Function *F, CallBase &Call) {
return false;
}
+bool CallAnalyzer::isLoweredToCall(Function *F, CallBase &Call) {
+ // Calls to memcpy with a known constant size 1/2/4/8 should not incur a call
+ // penalty, as the calls will be folded away by InstCombine. This is only
+ // really relevant on platforms whose headers redirect memcpy to __memcpy_chk
+ // (e.g. Mac), as other platforms use memcpy intrinsics, which are already
+ // exempt from the call penalty.
+ if (GetTLI) {
+ auto TLI = GetTLI(*F);
+ LibFunc LF;
+ if (TLI.getLibFunc(*F, LF) && TLI.has(LF)) {
----------------
fhahn wrote:
Perhaps something like below, which would need to duplicate the fallback
```suggestion
TargetLibraryInfo *TLI = GetTLI ? &GetTLI(*F) : nullptr;
LibFunc LF;
if (!TLI || !TLI->getLibFunc(*F, LF) || !TLI->has(LF) )
return TI.isLoweredToCall(F);
```
https://github.com/llvm/llvm-project/pull/117876
More information about the llvm-commits
mailing list