[llvm] [CMake] Handle clang in MSVC mode in GetHostTriple (PR #116701)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 01:21:54 PST 2024


================
@@ -2,7 +2,7 @@
 # Invokes config.guess
 
 function( get_host_triple var )
-  if( MSVC )
+  if( MSVC OR (CMAKE_SYSTEM_NAME STREQUAL "Windows" AND CMAKE_C_COMPILER_ID MATCHES "Clang" AND NOT MINGW AND NOT MSYS))
----------------
mstorsjo wrote:

Yeah, something like that would certainly be cleaner - but that would probably also be a much larger refactoring of the cmake code here.

Anyway, I'll accept the change here as I think this version should function correctly, but I don't mind such a restructuring either (maybe ideally as a separate step?).

https://github.com/llvm/llvm-project/pull/116701


More information about the llvm-commits mailing list