[llvm] [llvm][Comment] removing out-of-date comment, ARM backend no longer uses ScheduleDAGRRList (PR #117803)
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 26 17:08:38 PST 2024
================
@@ -314,9 +314,6 @@ ARMBaseRegisterInfo::getRegPressureLimit(const TargetRegisterClass *RC,
default:
return 0;
case ARM::tGPRRegClassID: {
- // hasFP ends up calling getMaxCallFrameComputed() which may not be
- // available when getPressureLimit() is called as part of
- // ScheduleDAGRRList.
bool HasFP = MF.getFrameInfo().isMaxCallFrameSizeComputed()
----------------
MatzeB wrote:
I don't think I remember any of this from years ago.
But if you remove the comment, shouldn't you also simplify the code to something like and see if anyone hits the assert?
```
assert(MF.getFrameInfo().isMaxCallFrameSizeComputed());
return 5 - TFI->hasFP(MF);
```
https://github.com/llvm/llvm-project/pull/117803
More information about the llvm-commits
mailing list