[llvm] Bail out jump threading on indirect branches (PR #103688)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 26 09:47:39 PST 2024


hiraditya wrote:

> Sorry for not following up here before...
> 
> > It didn't occur to me that there would be any violation of some sorts. I pushed the latest change last week and there wasn't any feedback since then.
> 
> Please see https://llvm.org/docs/CodeReview.html#code-review-workflow. If you submit a PR, you need to wait for an explicit approval. Ping the PR if needed. Lack of response is not the same as approval.

Ack.

> This PR did not even take into account the feedback that _was_ provided. If the test case had been properly minimized, it would have been clearer that this is not the correct bailout condition.

My bad, i'll try reducing the test case further. First attempt at reducing it was unsuccessful, commented as a follow up in your inline comment.

https://github.com/llvm/llvm-project/pull/103688


More information about the llvm-commits mailing list