[llvm] [BOLT] DataAggregator support for binaries with multiple text segments (PR #92815)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 26 05:55:31 PST 2024


zmodem wrote:

We're hitting test failures after this on Linux. From a build directory:

```
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=OFF -DLLVM_ENABLE_PROJECTS='clang;lld;bolt' -DLLVM_ENABLE_RUNTIMES=compiler-rt -DLLVM_TARGETS_TO_BUILD='AArch64;X86' ../llvm && ninja check-bolt
[...]
******************** TEST 'BOLT-Unit :: Core/./CoreTests/26/27' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/work/llvm-project/build.xx/tools/bolt/unittests/Core/./CoreTests-BOLT-Unit-989610-26-27.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=27 GTEST_SHARD_INDEX=26 /work/llvm-project/build.xx/tools/bolt/unittests/Core/./CoreTests
--

Script:
--
/work/llvm-project/build.xx/tools/bolt/unittests/Core/./CoreTests --gtest_filter=AArch64/MemoryMapsTester.MultipleSegmentsMismatchedBaseAddress/0
--
/work/llvm-project/bolt/unittests/Core/MemoryMaps.cpp:139: Failure
Death test: { Error Err = DA.preprocessProfile(*BC); }
    Result: failed to die.
 Error msg:
[  DEATH   ] BOLT-WARNING: build-id will not be checked because we could not read one from input binary
[  DEATH   ] Error reading BOLT data input file: line 4, column 5: expected decimal number
[  DEATH   ] Found: name
[  DEATH   ] PERF2BOLT: failed to parse samples
[  DEATH   ] Error reading BOLT data input file: line 4, column 10: expected decimal number
[  DEATH   ] Found: name
[  DEATH   ] PERF2BOLT: failed to parse memory events: Input/output error
[  DEATH   ] 


/work/llvm-project/bolt/unittests/Core/MemoryMaps.cpp:139
Death test: { Error Err = DA.preprocessProfile(*BC); }
    Result: failed to die.
 Error msg:
[  DEATH   ] BOLT-WARNING: build-id will not be checked because we could not read one from input binary
[  DEATH   ] Error reading BOLT data input file: line 4, column 5: expected decimal number
[  DEATH   ] Found: name
[  DEATH   ] PERF2BOLT: failed to parse samples
[  DEATH   ] Error reading BOLT data input file: line 4, column 10: expected decimal number
[  DEATH   ] Found: name
[  DEATH   ] PERF2BOLT: failed to parse memory events: Input/output error
[  DEATH   ] 



********************
********************
Failed Tests (2):
  BOLT-Unit :: Core/./CoreTests/AArch64/MemoryMapsTester/MultipleSegmentsMismatchedBaseAddress/0
  BOLT-Unit :: Core/./CoreTests/X86/MemoryMapsTester/MultipleSegmentsMismatchedBaseAddress/0


Testing Time: 3.13s

Total Discovered Tests: 489
  Skipped    :   7 (1.43%)
  Unsupported:  49 (10.02%)
  Passed     : 431 (88.14%)
  Failed     :   2 (0.41%)
```

Can you please take a look? I'll prepare a revert in the meantime.

https://github.com/llvm/llvm-project/pull/92815


More information about the llvm-commits mailing list