[llvm] [NFC][clang] Fix header comment in llvm/test/MC/AArch64/local-bounds-single-trap.ll (PR #117642)

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 15:07:27 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-aarch64

@llvm/pr-subscribers-mc

Author: Thurston Dang (thurstond)

<details>
<summary>Changes</summary>

llvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in https://github.com/llvm/llvm-project/pull/65972 to demonstrate that nomerge did not work properly, which is documented in the header comment.

https://github.com/llvm/llvm-project/pull/101549 fixed nomerge for trap builtins and https://github.com/llvm/llvm-project/commit/ae6dc64ec670891cb15049277e43133d4df7fb4b updated the test assertions, but not the header comment. This patch updates the header comment accordingly.

---
Full diff: https://github.com/llvm/llvm-project/pull/117642.diff


1 Files Affected:

- (modified) llvm/test/MC/AArch64/local-bounds-single-trap.ll (+4-3) 


``````````diff
diff --git a/llvm/test/MC/AArch64/local-bounds-single-trap.ll b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
index 6a017e24ab3cdf..8b8a3e430df692 100644
--- a/llvm/test/MC/AArch64/local-bounds-single-trap.ll
+++ b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
@@ -1,7 +1,8 @@
 ; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM
-; What this test does is check that even with nomerge, the functions still get merged in
-; compiled code as the ubsantrap call gets lowered to a single instruction: brk.
-
+; This test checks that nomerge correctly prevents the traps from being merged
+; in the compiled code.
+; Prior to ae6dc64ec670891cb15049277e43133d4df7fb4b, this test showed that
+; nomerge did not work correctly.
 
 @B = dso_local global [10 x i8] zeroinitializer, align 1
 @B2 = dso_local global [10 x i8] zeroinitializer, align 1

``````````

</details>


https://github.com/llvm/llvm-project/pull/117642


More information about the llvm-commits mailing list