[llvm] [NFC][clang] Fix header comment in llvm/test/MC/AArch64/local-bounds-single-trap.ll (PR #117642)

Thurston Dang via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 15:06:53 PST 2024


https://github.com/thurstond created https://github.com/llvm/llvm-project/pull/117642

llvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in https://github.com/llvm/llvm-project/pull/65972/files to demonstrate that nomerge did not work properly, which is documented in the header comment.

https://github.com/llvm/llvm-project/pull/101549 fixed nomerge for trap builtins and https://github.com/llvm/llvm-project/commit/ae6dc64ec670891cb15049277e43133d4df7fb4b updated the test assertions, but not the header comment. This patch updates the header comment accordingly.

>From ddec5e43f4b8b0813c26698c4ce37044c5727f3c Mon Sep 17 00:00:00 2001
From: Thurston Dang <thurston at google.com>
Date: Mon, 25 Nov 2024 23:04:03 +0000
Subject: [PATCH] [clang] Fix header comment in
 llvm/test/MC/AArch64/local-bounds-single-trap.ll

llvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in https://github.com/llvm/llvm-project/pull/65972/files to demonstrate that nomerge did not work properly, which is documented in the header comment.

https://github.com/llvm/llvm-project/pull/101549 fixed nomerge for trap builtins and https://github.com/llvm/llvm-project/commit/ae6dc64ec670891cb15049277e43133d4df7fb4b updated the test assertions, but not the header comment. This patch updates the header comment accordingly.
---
 llvm/test/MC/AArch64/local-bounds-single-trap.ll | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/llvm/test/MC/AArch64/local-bounds-single-trap.ll b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
index 6a017e24ab3cdf..8b8a3e430df692 100644
--- a/llvm/test/MC/AArch64/local-bounds-single-trap.ll
+++ b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
@@ -1,7 +1,8 @@
 ; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM
-; What this test does is check that even with nomerge, the functions still get merged in
-; compiled code as the ubsantrap call gets lowered to a single instruction: brk.
-
+; This test checks that nomerge correctly prevents the traps from being merged
+; in the compiled code.
+; Prior to ae6dc64ec670891cb15049277e43133d4df7fb4b, this test showed that
+; nomerge did not work correctly.
 
 @B = dso_local global [10 x i8] zeroinitializer, align 1
 @B2 = dso_local global [10 x i8] zeroinitializer, align 1



More information about the llvm-commits mailing list