[llvm] [CodeGen][NewPM] Port RegAllocEvictionAdvisor analysis to NPM (PR #117309)

Akshat Oke via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 24 22:57:34 PST 2024


optimisan wrote:

> In general we should avoid module analysis results here. I browsed the relevant codes here, some machine learning based advisors need to load external models so they need `doInitialization`. Could we load and check models while building the pipeline?

Could you explain why to avoid module analysis results? 
Here iiuc we need to setup the Runner and Logger once, and then can provide the advisor. We can do that in the constructor of the NPM analysis and I'll change it to an MF analysis so this analysis owns the provider state (instead of being a module analysis).

https://github.com/llvm/llvm-project/pull/117309


More information about the llvm-commits mailing list