[llvm] [X86, SimplifyCFG] Support hoisting load/store with conditional faulting (Part II) (PR #108812)

Shengchen Kan via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 24 18:37:22 PST 2024


================
@@ -1664,18 +1664,35 @@ static bool areIdenticalUpToCommutativity(const Instruction *I1,
 static void hoistConditionalLoadsStores(
     BranchInst *BI,
     SmallVectorImpl<Instruction *> &SpeculatedConditionalLoadsStores,
-    bool Invert) {
+    std::optional<bool> Invert) {
----------------
KanRobert wrote:

Add a comment like
```
\param Invert  ...
```
?

It's a little hard to know when it's nullopt w/o searching for the caller.

https://github.com/llvm/llvm-project/pull/108812


More information about the llvm-commits mailing list