[llvm] [AMDGPU] Fix AMDGPUISD::TRAP description (PR #117453)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 23 16:16:51 PST 2024


https://github.com/s-barannikov created https://github.com/llvm/llvm-project/pull/117453

Glue operand is only present if there are variadic register operands, which makes it optional.
Also, change the number of fixed operands to 1 (the trap ID).


>From ebff5ad479138ec4ed17fbf870dd93763d22e49f Mon Sep 17 00:00:00 2001
From: Sergei Barannikov <barannikov88 at gmail.com>
Date: Sun, 24 Nov 2024 03:14:16 +0300
Subject: [PATCH] [AMDGPU] Fix AMDGPUISD::TRAP description

* the node always has one *fixed* argument, which is the trap id
* glue operand is only present if there are variadic register operands
---
 llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td b/llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
index 702f6e67c55271..bec294a945d2fe 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
@@ -100,8 +100,8 @@ def AMDGPUtc_return_chain: SDNode<"AMDGPUISD::TC_RETURN_CHAIN",
 >;
 
 def AMDGPUtrap : SDNode<"AMDGPUISD::TRAP",
-  SDTypeProfile<0, -1, [SDTCisVT<0, i16>]>,
-    [SDNPHasChain, SDNPVariadic, SDNPSideEffect, SDNPInGlue]
+  SDTypeProfile<0, 1, [SDTCisVT<0, i16>]>,
+    [SDNPHasChain, SDNPVariadic, SDNPSideEffect, SDNPOptInGlue]
 >;
 
 def AMDGPUconstdata_ptr : SDNode<



More information about the llvm-commits mailing list