[llvm] [X86] Fix the type of X86ISD::UMUL (PR #117377)
Sergei Barannikov via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 22 15:29:19 PST 2024
================
@@ -266,7 +261,7 @@ def X86add_flag : SDNode<"X86ISD::ADD", SDTBinaryArithWithFlags,
def X86sub_flag : SDNode<"X86ISD::SUB", SDTBinaryArithWithFlags>;
def X86smul_flag : SDNode<"X86ISD::SMUL", SDTBinaryArithWithFlags,
[SDNPCommutative]>;
-def X86umul_flag : SDNode<"X86ISD::UMUL", SDT2ResultBinaryArithWithFlags,
+def X86umul_flag : SDNode<"X86ISD::UMUL", SDTBinaryArithWithFlags,
----------------
s-barannikov wrote:
I would rather keep it. `UMUL` is created by `X86ISelLowering` and having a description in a td file would allow generating various info from it (a feature I'm currently working on but haven't created an RFC yet).
https://github.com/llvm/llvm-project/pull/117377
More information about the llvm-commits
mailing list