[clang] [llvm] [HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (PR #114148)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 13:15:41 PST 2024


================
@@ -12528,6 +12530,10 @@ def warn_attr_min_eq_max:  Warning<
 
 def err_hlsl_attribute_number_arguments_insufficient_shader_model: Error<
   "attribute %0 with %1 arguments requires shader model %2 or greater">;
+def err_hlsl_expect_arg_const_int_one_or_neg_one: Error<
+  "argument %0 must be constant integer 1 or -1">;
+def err_invalid_hlsl_resource_type: Error<
+  "invalid __hlsl_resource_t type attributes">;
----------------
bogner wrote:

These messages feel like they're generic enough that we could reuse some existing diagnostic, but I don't really see anything that works. These are probably fine, but we should make sure to pay attention to adding too many new diagnostics if/when we don't need to.

https://github.com/llvm/llvm-project/pull/114148


More information about the llvm-commits mailing list