[clang] [llvm] [HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (PR #114148)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 22 13:15:40 PST 2024


================
@@ -19371,6 +19371,15 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
         CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef<Value *>{Op0},
         nullptr, "hlsl.radians");
   }
+  case Builtin::BI__builtin_hlsl_buffer_update_counter: {
+    Value *ResHandle = EmitScalarExpr(E->getArg(0));
+    Value *Offset = EmitScalarExpr(E->getArg(1));
+    Value *Offset_i8 = Builder.CreateIntCast(Offset, Int8Ty, true);
----------------
bogner wrote:

Underscores in names don't really fit the LLVM style. `OffsetI8`, `I8Offset`, or even just `Cast` would be a better name

https://github.com/llvm/llvm-project/pull/114148


More information about the llvm-commits mailing list