[llvm] [TableGen] Remove comments from generated validateOperandClass (PR #117352)
    via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Nov 22 09:39:32 PST 2024
    
    
  
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-tablegen
Author: Jay Foad (jayfoad)
<details>
<summary>Changes</summary>
This generated comments like:
  // 'BoolReg' class
  case MCK_BoolReg: {
which seem redundant because the name is always repeated on the next
line as part of the MCK_ enumerator.
---
Full diff: https://github.com/llvm/llvm-project/pull/117352.diff
1 Files Affected:
- (modified) llvm/utils/TableGen/AsmMatcherEmitter.cpp (-1) 
``````````diff
diff --git a/llvm/utils/TableGen/AsmMatcherEmitter.cpp b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
index ade393c11b7a24..82f28ad38b9363 100644
--- a/llvm/utils/TableGen/AsmMatcherEmitter.cpp
+++ b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
@@ -2491,7 +2491,6 @@ static void emitValidateOperandClass(AsmMatcherInfo &Info, raw_ostream &OS) {
     if (!CI.isUserClass())
       continue;
 
-    OS << "  // '" << CI.ClassName << "' class\n";
     OS << "  case " << CI.Name << ": {\n";
     OS << "    DiagnosticPredicate DP(Operand." << CI.PredicateMethod
        << "());\n";
``````````
</details>
https://github.com/llvm/llvm-project/pull/117352
    
    
More information about the llvm-commits
mailing list