[llvm] [SPIR-V] Fixup storage class for global private (PR #116636)

[Vyacheslav Levytskyy via llvm-commits]

Nathan =?utf-8?q?Gauër?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/116636 at github.com>


================
@@ -3264,9 +3264,15 @@ bool SPIRVInstructionSelector::selectGlobalValue(
     PointerBaseType = GR.getOrCreateSPIRVType(
         GVType, MIRBuilder, SPIRV::AccessQualifier::ReadWrite, false);
   }
-  SPIRVType *ResType = GR.getOrCreateSPIRVPointerType(
-      PointerBaseType, I, TII,
-      addressSpaceToStorageClass(GV->getAddressSpace(), STI));
+
+  const unsigned AddrSpace = GV->getAddressSpace();
+  SPIRV::StorageClass::StorageClass StorageClass =
+      addressSpaceToStorageClass(AddrSpace, STI);
+  if (StorageClass == SPIRV::StorageClass::Function)
+    StorageClass = SPIRV::StorageClass::Private;
----------------
VyacheslavLevytskyy wrote:

E.g., something along the lines of

```
bool SPIRVEmitIntrinsics::runOnModule(Module &M) {
  bool Changed = false;

  for (auto GV = M.global_begin(), GE = M.global_end(); GV != GE; ++GV) {
    if (isa<Function>(GV) || GV->getAddressSpace() != storageClassToAddressSpace(SPIRV::StorageClass::Function))
      continue;
    // add to worklist
  }
  // traverse worklist, re-create the global in another address space GV->replaceAllUsesWith(newGV);
```

https://github.com/llvm/llvm-project/pull/116636