[clang] [lld] [llvm] [WebAssembly] Define call-indirect-overlong and bulk-memory-opt features (PR #117087)

Heejin Ahn via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 19:22:45 PST 2024


================
@@ -1,7 +1,7 @@
-; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mcpu=mvp -mattr=+bulk-memory | FileCheck %s --check-prefixes CHECK,BULK-MEM
-; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mcpu=mvp -mattr=-bulk-memory | FileCheck %s --check-prefixes CHECK,NO-BULK-MEM
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mcpu=mvp -mattr=+bulk-memory-opt | FileCheck %s --check-prefixes CHECK,BULK-MEM
----------------
aheejin wrote:

Do we need to replace the current `-mattr=+bulk-memory` with `+bulk-memory-opt` in all the tests where it doesn't matter? I am not strongly opinionated whether we should or should not add the non-Wasm-proposal features, but I'm not sure whether it should be used in all the tests instead of the old features.

https://github.com/llvm/llvm-project/pull/117087


More information about the llvm-commits mailing list