[llvm] [ARM] Stop gluing FP comparisons to FMSTAT (PR #116676)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 13:15:21 PST 2024


mstorsjo wrote:

> The machine verifier error above is wrong, the immediate _is_ valid. `verifyInstruction` calls `isLegalAddressImm` with an encoded immediate, while the function seems to expect a decoded (scaled by 4) value.
> 
> These instruction have `t2addrmode_imm7s4` operands. Do I understand correctly that these instructions do not exist in ARM mode? CC @ostannard

Hmmm - but when running the generated code, execution fails with Illegal instruction, both for ARM and Thumb mode. So even if the immediate may be valid, there's something wrong with the generated code here still...

https://github.com/llvm/llvm-project/pull/116676


More information about the llvm-commits mailing list