[llvm] [NFC] Add `const` for readability (PR #116611)

Jessica Clarke via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 10:48:11 PST 2024


================
@@ -581,30 +581,30 @@ class InnerLoopVectorizer {
   virtual void printDebugTracesAtEnd() {}
 
   /// The original loop.
-  Loop *OrigLoop;
+  Loop *const OrigLoop;
 
   /// A wrapper around ScalarEvolution used to add runtime SCEV checks. Applies
   /// dynamic knowledge to simplify SCEV expressions and converts them to a
   /// more usable form.
   PredicatedScalarEvolution &PSE;
 
   /// Loop Info.
-  LoopInfo *LI;
+  LoopInfo *const LI;
----------------
jrtc27 wrote:

Yeah, that's what it's saying. But there are so many places in LLVM where we _could_ have const but don't. There's a real risk of putting const everywhere and it being less readable as a result.

https://github.com/llvm/llvm-project/pull/116611


More information about the llvm-commits mailing list