[llvm] [X86] Add APX imulzu support. (PR #116806)

Phoebe Wang via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 01:37:13 PST 2024


================
@@ -58919,6 +58919,12 @@ bool X86TargetLowering::IsDesirableToPromoteOp(SDValue Op, EVT &PVT) const {
     if (IsFoldableAtomicRMW(N0, Op) ||
         (Commute && IsFoldableAtomicRMW(N1, Op)))
       return false;
+    // When ZU is enabled, we prefer to not promote for MUL by a constant,
+    // since a 16b imulzu will not incur partial-write stalls, and may be
+    // able to fold away a zero-extend of the 16b result.
+    if (Subtarget.hasZU() && Op.getOpcode() == ISD::MUL &&
+        (isa<ConstantSDNode>(N0) || isa<ConstantSDNode>(N1)))
----------------
phoebewang wrote:

I think there is difference here. https://github.com/llvm/llvm-project/commit/20683de70e43fa73536ac1e8ce4082604048d040 is NDD instruction, so it can be folded when profitable.

https://github.com/llvm/llvm-project/pull/116806


More information about the llvm-commits mailing list