[llvm] [Coroutines][Swift] Remove replaceSwiftErrorOps while cloning (PR #116292)

Tyler Nowicki via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 13:15:41 PST 2024


TylerNowicki wrote:

Thanks for the details! Do you know if it is possible to detect when swift is being used? I am refactoring the cloner to try to isolate the code required for each abi. https://github.com/llvm/llvm-project/pull/116885 I feel it would be best to isolate swift code in a similar fashion by inheriting the base cloner and implementing the changes needed for swift on top.

Also, perhaps you noticed the new custom ABI object I introduced earlier [1]? I believe that could be used to pull the swift code out of the LLVM repo entirely (mostly). Instead, the swift compiler would implement the changes it needs right in its own repo. At least it is worth a look to see if that is possible. I am not working on swift but perhaps you know someone who might be interested in looking at that?

[1] - https://llvm.org/docs/Coroutines.html#custom-abis-and-plugin-libraries

https://github.com/llvm/llvm-project/pull/116292


More information about the llvm-commits mailing list