[llvm] [memprof] Use LineLocation in a unit test (NFC) (PR #117031)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 11:06:42 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
We've switched to LineLocation from FieldsAre in MemProfUseTest.cpp.
This patch does the same thing in InstrProfTest.cpp.
llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
---
Full diff: https://github.com/llvm/llvm-project/pull/117031.diff
1 Files Affected:
- (modified) llvm/unittests/ProfileData/InstrProfTest.cpp (+6-4)
``````````diff
diff --git a/llvm/unittests/ProfileData/InstrProfTest.cpp b/llvm/unittests/ProfileData/InstrProfTest.cpp
index 5a313aa4182a54..3beab8976304ef 100644
--- a/llvm/unittests/ProfileData/InstrProfTest.cpp
+++ b/llvm/unittests/ProfileData/InstrProfTest.cpp
@@ -25,8 +25,10 @@
#include <optional>
using namespace llvm;
+using ::llvm::memprof::LineLocation;
using ::testing::EndsWith;
using ::testing::IsSubsetOf;
+using ::testing::Pair;
using ::testing::SizeIs;
using ::testing::UnorderedElementsAre;
@@ -620,18 +622,18 @@ TEST_F(InstrProfTest, test_caller_callee_pairs) {
auto It = Pairs.find(0x123);
ASSERT_NE(It, Pairs.end());
ASSERT_THAT(It->second, SizeIs(2));
- EXPECT_THAT(It->second[0], testing::Pair(testing::FieldsAre(1U, 2U), 0x234U));
- EXPECT_THAT(It->second[1], testing::Pair(testing::FieldsAre(5U, 6U), 0x345U));
+ EXPECT_THAT(It->second[0], Pair(LineLocation(1, 2), 0x234U));
+ EXPECT_THAT(It->second[1], Pair(LineLocation(5, 6), 0x345U));
It = Pairs.find(0x234);
ASSERT_NE(It, Pairs.end());
ASSERT_THAT(It->second, SizeIs(1));
- EXPECT_THAT(It->second[0], testing::Pair(testing::FieldsAre(3U, 4U), 0U));
+ EXPECT_THAT(It->second[0], Pair(LineLocation(3, 4), 0U));
It = Pairs.find(0x345);
ASSERT_NE(It, Pairs.end());
ASSERT_THAT(It->second, SizeIs(1));
- EXPECT_THAT(It->second[0], testing::Pair(testing::FieldsAre(7U, 8U), 0U));
+ EXPECT_THAT(It->second[0], Pair(LineLocation(7, 8), 0U));
}
TEST_F(InstrProfTest, test_memprof_getrecord_error) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/117031
More information about the llvm-commits
mailing list