[flang] [llvm] [flang][OpenMP] Change clause modifier representation in parser (PR #116656)

Wed Nov 20 09:43:05 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-out-of-tree` running on `linaro-flang-aarch64-out-of-tree` while building `flang,llvm` at step 7 "build-flang-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds/8216

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-flang-unified-tree) failure: build (failure)
...
1104.810 [202/46/120] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/canonicalize-directives.cpp.o
1107.337 [202/45/121] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/IterationSpace.cpp.o
1107.596 [202/44/122] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-acc-structure.cpp.o
1110.972 [202/43/123] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/HostAssociations.cpp.o
1112.958 [202/42/124] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/VectorSubscripts.cpp.o
1114.575 [202/41/125] Building CXX object lib/Parser/CMakeFiles/FortranParser.dir/openmp-parsers.cpp.o
1121.704 [202/40/126] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/ConvertExprToHLFIR.cpp.o
1122.845 [202/39/127] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/ConvertVariable.cpp.o
1125.121 [202/38/128] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/canonicalize-acc.cpp.o
1125.581 [202/37/129] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/openmp-modifiers.cpp.o
FAILED: lib/Semantics/CMakeFiles/FortranSemantics.dir/openmp-modifiers.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_flang/lib/Semantics -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/lib/Semantics -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_flang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/tools/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/clang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/tools/clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17   -D_GNU_SOURCE -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Semantics/CMakeFiles/FortranSemantics.dir/openmp-modifiers.cpp.o -MF lib/Semantics/CMakeFiles/FortranSemantics.dir/openmp-modifiers.cpp.o.d -o lib/Semantics/CMakeFiles/FortranSemantics.dir/openmp-modifiers.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/lib/Semantics/openmp-modifiers.cpp
In file included from ../llvm-project/flang/lib/Semantics/openmp-modifiers.cpp:9:
../llvm-project/flang/include/flang/Semantics/openmp-modifiers.h:45:69: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
   45 | ENUM_CLASS(OmpProperty, Required, Unique, Exclusive, Ultimate, Post);
      |                                                                     ^
1 error generated.
1126.413 [202/36/130] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-return.cpp.o
1129.445 [202/35/131] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-io.cpp.o
1130.765 [202/34/132] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-purity.cpp.o
1131.897 [202/33/133] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-select-type.cpp.o
1132.300 [202/32/134] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/program-tree.cpp.o
1136.172 [202/31/135] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-stop.cpp.o
1138.320 [202/30/136] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-namelist.cpp.o
1139.921 [202/29/137] Building CXX object lib/Parser/CMakeFiles/FortranParser.dir/openacc-parsers.cpp.o
1140.641 [202/28/138] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/definable.cpp.o
1147.859 [202/27/139] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenMP/Decomposer.cpp.o
1148.893 [202/26/140] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-declarations.cpp.o
1150.393 [202/25/141] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/resolve-labels.cpp.o
1151.426 [202/24/142] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/Bridge.cpp.o
1151.537 [202/23/143] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/data-to-inits.cpp.o
1151.769 [202/22/144] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/compute-offsets.cpp.o
1151.875 [202/21/145] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenMP/Clauses.cpp.o
1165.558 [202/20/146] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenMP/Utils.cpp.o
1171.786 [202/19/147] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/mod-file.cpp.o
1175.317 [202/18/148] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/pointer-assignment.cpp.o
1175.642 [202/17/149] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenMP/ClauseProcessor.cpp.o
1187.173 [202/16/150] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-cuda.cpp.o
1188.393 [202/15/151] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-omp-structure.cpp.o
1188.929 [202/14/152] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-call.cpp.o
1196.865 [202/13/153] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-do-forall.cpp.o
1207.522 [202/12/154] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/resolve-directives.cpp.o
1219.420 [202/11/155] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/ConvertExpr.cpp.o
1222.218 [202/10/156] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-case.cpp.o
1224.450 [202/9/157] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenACC.cpp.o
1231.142 [202/8/158] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/PFTBuilder.cpp.o
1234.917 [202/7/159] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/expression.cpp.o
1236.598 [202/6/160] Building CXX object lib/Lower/CMakeFiles/FortranLower.dir/OpenMP/DataSharingProcessor.cpp.o
1245.741 [202/5/161] Building CXX object lib/Semantics/CMakeFiles/FortranSemantics.dir/check-select-rank.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/116656