[llvm] [X86] Recognize POP/ADD/SUB modifying rsp in getSPAdjust. (PR #114265)

Björn Pettersson via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 06:28:15 PST 2024


bjope wrote:

Ping!

Would be nice to know if you need more information (I could probably make a runnable C-level reproducer, but if the already provided reproducers are good enough I rather not spend time on that)?

Considering that we've seen lots of failing tests (runtime failures) starting to happen with this patch, maybe it should be reverted until someone has analyzed these problems?

@phoebewang, @RKSimon and @e-kud  : I can't even see that @daniel-zabawa has a registered email address. So unsure if pinging here actually will lead to anything? I guess we shouldn't accept patches from people that aren't following up on problems found when landing patches?

https://github.com/llvm/llvm-project/pull/114265


More information about the llvm-commits mailing list