[llvm] [LICM] allow MemoryAccess creation failure (PR #116813)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 20 00:40:59 PST 2024


================
@@ -0,0 +1,24 @@
+; RUN: opt -passes='loop-mssa(simple-loop-unswitch<nontrivial>),print<memoryssa>' -verify-memoryssa -disable-output -S < %s 2>&1 | FileCheck %s
----------------
nikic wrote:

Can you please change this to a normal test using update_test_checks.py? I don't think your check for MemoryDef really adds anything here, as it would *also* be correct to not have the MemoryDef, so this is kind of testing an implementation detail.

https://github.com/llvm/llvm-project/pull/116813


More information about the llvm-commits mailing list