[llvm] [DebugInfo][LoopIdiomRecognize] Fix #82582: Wrong debug location update in processLoopStridedStore (PR #82723)
Shan Huang via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 23:49:33 PST 2024
Apochens wrote:
Hi @OCHyams! I'm glad to have this PR ready for merging. However, I just realized that there is [an open PR addressing a similar case](https://github.com/llvm/llvm-project/pull/82608), and in that PR, dropping the location concerns other developers:
> However, if a developer passes an invalid pointer into the relevant function and there's a crash, with this patch they won't get a source location for where that crash came from which is catastrophic for their ability to debug what went wrong.
It seems that although dropping the debug location is the correct thing to do, crash logs without accurate source locations are annoying...
https://github.com/llvm/llvm-project/pull/82723
More information about the llvm-commits
mailing list