[compiler-rt] [win/asan] Support instructions in GetInstructionSize used by Wine. (PR #113085)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 02:52:48 PST 2024


Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/113085 at github.com>


================
@@ -643,6 +664,8 @@ static size_t GetInstructionSize(uptr address, size_t* rel_offset = nullptr) {
     case 0x7980:  // 80 79 YY XX  cmp BYTE ptr [rcx+YY], XX
       return 4;
 
+    case 0xB841:  // 41 B8 XX XX XX XX : mov r8d, XX XX XX XX
----------------
alvinhochun wrote:

This looks wrong. The second operand is an immediate, not a relative offset, so it shouldn't be leading to a branch that sets `rel_offset`.

https://github.com/llvm/llvm-project/pull/113085


More information about the llvm-commits mailing list