[compiler-rt] [win/asan] Support instructions in GetInstructionSize used by Wine. (PR #113085)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 02:03:08 PST 2024


Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>,
Bernhard =?utf-8?q?Übelacker?= <bernhardu at mailbox.org>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/113085 at github.com>


================
@@ -658,7 +681,6 @@ static size_t GetInstructionSize(uptr address, size_t* rel_offset = nullptr) {
   }
 
   switch (0x00FFFFFF & *(u32*)address) {
-    case 0x07c1f6:    // f6 c1 07 : test cl, 0x7
----------------
bernhardu wrote:

That `f6 c1 07 : test cl, 0x7` got moved into the generic form `F6 C1 XX : test cl, XX`.
I tried to document this by moving it into separate commits before the "big" one.

https://github.com/llvm/llvm-project/pull/113085


More information about the llvm-commits mailing list