[llvm] [ORC] Reduce `SymbolStringPtr` usage in `InProgressLookupSet` #55576 (PR #116743)

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 21:20:52 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c7df10643bda4acdc9a02406a2eee8aa4ced747f 99d2bac980c8425df155d8344c3851f769209b21 --extensions cpp,h -- llvm/include/llvm/ExecutionEngine/Orc/Core.h llvm/include/llvm/ExecutionEngine/Orc/DebugUtils.h llvm/lib/ExecutionEngine/Orc/Core.cpp llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ExecutionEngine/Orc/Core.cpp b/llvm/lib/ExecutionEngine/Orc/Core.cpp
index 0bd85fd857..320b8bd3b5 100644
--- a/llvm/lib/ExecutionEngine/Orc/Core.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/Core.cpp
@@ -2386,9 +2386,11 @@ void ExecutionSession::OL_applyQueryPhase1(
       // non-candidates to the empty set.
       NonOwningSymbolLookupSet Tmp;
       std::swap(IPLS->DefGeneratorNonCandidates, Tmp);
-      IPLS->DefGeneratorCandidates.reserve(IPLS->DefGeneratorCandidates.size() + IPLS->DefGeneratorCandidates.size());
+      IPLS->DefGeneratorCandidates.reserve(IPLS->DefGeneratorCandidates.size() +
+                                           IPLS->DefGeneratorCandidates.size());
       for (auto &KV : Tmp)
-        IPLS->DefGeneratorCandidates.emplace_back(NonOwningSymbolStringPtr(KV.first), KV.second);
+        IPLS->DefGeneratorCandidates.emplace_back(
+            NonOwningSymbolStringPtr(KV.first), KV.second);
 
       LLVM_DEBUG({
         dbgs() << "  First time visiting " << JD.getName()

``````````

</details>


https://github.com/llvm/llvm-project/pull/116743


More information about the llvm-commits mailing list