[llvm] [GlobalISel] Combine [S,U]SUBO (PR #116489)

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 17:45:54 PST 2024


Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/116489 at github.com>


aemerson wrote:

I have another request in general for your changes. Could you please add some more appropriate descriptions to your PRs so that when you merge them, we end up with a better commit message?

For example, for this commit, we could've done with a description of what the actual combine did. Instead, we got some commentary on some implementation details that aren't very helpful to the reader of the commit.

https://github.com/llvm/llvm-project/pull/116489


More information about the llvm-commits mailing list