[llvm] Add a pass to collect dropped var stats for MIR. (PR #115566)

Mon Nov 18 16:02:57 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `llvm` at step 7 "test-build-unified-tree-check-llvm-unit".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/11319

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-build-unified-tree-check-llvm-unit) failure: test (failure)
...
[669/723] Linking CXX executable unittests\Transforms\Vectorize\VectorizeTests.exe
[670/723] Linking CXX executable unittests\Transforms\IPO\IPOTests.exe
[671/723] Linking CXX executable unittests\Passes\PassBuilderBindings\PassesBindingsTests.exe
[672/723] Linking CXX executable unittests\Target\TargetMachineCTests.exe
[673/723] Linking CXX executable unittests\tools\llvm-exegesis\LLVMExegesisTests.exe
[674/723] Linking CXX executable unittests\Transforms\Coroutines\CoroTests.exe
[675/723] Linking CXX executable unittests\Transforms\Instrumentation\InstrumentationTests.exe
[676/723] Linking CXX executable unittests\Transforms\Utils\UtilsTests.exe
[677/723] Linking CXX executable unittests\Transforms\Scalar\ScalarTests.exe
[678/723] Building CXX object unittests\MIR\CMakeFiles\MIRTests.dir\DroppedVariableStatsMIRTest.cpp.obj
FAILED: unittests/MIR/CMakeFiles/MIRTests.dir/DroppedVariableStatsMIRTest.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\unittests\MIR -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googletest\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Founittests\MIR\CMakeFiles\MIRTests.dir\DroppedVariableStatsMIRTest.cpp.obj /Fdunittests\MIR\CMakeFiles\MIRTests.dir\ /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(35): error C2065: 'LLVMTargetMachine': undeclared identifier
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(35): error C2923: 'std::unique_ptr': 'LLVMTargetMachine' is not a valid template type argument for parameter '_Ty'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(35): note: see declaration of 'LLVMTargetMachine'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(35): error C2976: 'std::unique_ptr': too few template arguments
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3203): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(36): error C2955: 'std::unique_ptr': use of class template requires template argument list
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3203): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(36): error C2079: '`anonymous-namespace'::createTargetMachine' uses undefined class 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(40): error C2440: 'return': cannot convert from 'nullptr' to 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(40): note: 'std::unique_ptr<_Ty,_Dx>::unique_ptr(const std::unique_ptr<_Ty,_Dx> &)': cannot convert 'this' pointer from 'std::unique_ptr' to 'std::unique_ptr<_Ty,_Dx> &'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(40): note: Reason: cannot convert from 'std::unique_ptr' to 'std::unique_ptr<_Ty,_Dx>'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(40): note: Conversion requires a second user-defined-conversion operator or constructor
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3246): note: could be 'std::unique_ptr<_Ty,_Dx>::unique_ptr(std::unique_ptr<_Ux,_Dx> &&) noexcept'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3238): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(std::unique_ptr<_Ty,_Dx> &&) noexcept'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3235): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(_Get_deleter_pointer_type<_Ty,remove_reference<_Ty1>::type,void>::type,remove_reference<_Ty1>::type &&)'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3230): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(_Get_deleter_pointer_type<_Ty,remove_reference<_Ty1>::type,void>::type,_Dx &&) noexcept'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3226): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(_Get_deleter_pointer_type<_Ty,remove_reference<_Ty1>::type,void>::type,const _Dx &) noexcept'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3213): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(std::nullptr_t) noexcept'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3210): note: or       'std::unique_ptr<_Ty,_Dx>::unique_ptr(void) noexcept'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(40): note: while trying to match the argument list '(nullptr)'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(42): error C2065: 'LLVMTargetMachine': undeclared identifier
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(42): error C2923: 'std::unique_ptr': 'LLVMTargetMachine' is not a valid template type argument for parameter '_Ty'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(42): note: see declaration of 'LLVMTargetMachine'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(42): error C2976: 'std::unique_ptr': too few template arguments
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3203): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(43): error C2061: syntax error: identifier 'LLVMTargetMachine'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(184): error C2641: cannot deduce template arguments for 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(184): error C2783: 'std::unique_ptr<_Ty,_Dx> std::unique_ptr(std::nullptr_t) noexcept': could not deduce template argument for '_Ty'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3213): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(184): error C2780: 'std::unique_ptr<_Ty,_Dx> std::unique_ptr(void) noexcept': expects 0 arguments - 1 provided
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3210): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(184): error C2784: 'std::unique_ptr<_Ty,_Dx> std::unique_ptr(std::unique_ptr<_Ty,_Dx>)': could not deduce template argument for 'std::unique_ptr<_Ty,_Dx>' from 'std::unique_ptr'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3203): note: see declaration of 'std::unique_ptr'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(185): error C2662: '_Get_deleter_pointer_type<_Ty,remove_reference<_Ty1>::type,void>::type std::unique_ptr<_Ty,_Dx>::get(void) noexcept const': cannot convert 'this' pointer from 'std::unique_ptr' to 'const std::unique_ptr<_Ty,_Dx> &'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(185): note: Reason: cannot convert from 'std::unique_ptr' to 'const std::unique_ptr<_Ty,_Dx>'
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\unittests\MIR\DroppedVariableStatsMIRTest.cpp(185): note: Conversion requires a second user-defined-conversion operator or constructor
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include\memory(3300): note: see declaration of 'std::unique_ptr<_Ty,_Dx>::get'

```

</details>

https://github.com/llvm/llvm-project/pull/115566