[llvm] [NVPTX] Optimize v2x16 BUILD_VECTORs to PRMT (PR #116675)

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 14:00:09 PST 2024


================
@@ -6176,6 +6176,57 @@ static SDValue PerformLOADCombine(SDNode *N,
       DL);
 }
 
+static SDValue
+PerformBUILD_VECTORCombine(SDNode *N, TargetLowering::DAGCombinerInfo &DCI) {
+  auto VT = N->getValueType(0);
+  if (!DCI.isAfterLegalizeDAG() || !Isv2x16VT(VT))
+    return SDValue();
+
+  auto Op0 = N->getOperand(0);
+  auto Op1 = N->getOperand(1);
+
+  // Start out by assuming we want to take the lower 2 bytes of each i32
+  // operand.
+  uint64_t Op0Bytes = 0x10;
+  uint64_t Op1Bytes = 0x54;
+
+  std::pair<SDValue *, uint64_t *> OpData[2] = {{&Op0, &Op0Bytes},
+                                                {&Op1, &Op1Bytes}};
+
+  // Check that each operand is an i16, truncated from an i32 operand. We'll
+  // select individual bytes from those original operands. Optionally, fold in a
+  // shift right of that original operand.
+  for (auto &[Op, OpBytes] : OpData) {
+    // Eat up any bitcast
+    if (Op->getOpcode() == ISD::BITCAST)
+      *Op = Op->getOperand(0);
+
+    if (Op->getValueType() != MVT::i16 || Op->getOpcode() != ISD::TRUNCATE ||
+        Op->getOperand(0).getValueType() != MVT::i32)
+      return SDValue();
+
+    *Op = Op->getOperand(0);
+
+    // Optionally, fold in a shift-right of the original operand and permute
+    // the two higher bytes from the shifted operand
+    if (Op->getOpcode() == ISD::SRL && isa<ConstantSDNode>(Op->getOperand(1))) {
+      if (cast<ConstantSDNode>(Op->getOperand(1))->getZExtValue() == 16) {
+        *OpBytes += 0x22;
+        *Op = Op->getOperand(0);
+      }
+    }
----------------
Artem-B wrote:

> This seems like a separate optimization to me: prmt a (shr b [8|16|24]) x -> prmt a b y.

One way we could generalize that is via two-step process:
- convert shifts and truncates by 8/16/24, vector extraction of i8/i16 into `prmt`, This give us convenient access to an i32 and a mask of valid bits in it. E.g. `shr b,16` -> `prmt b, 0, 0x4410`.
- then combine individual i32s with partial values into one. E.g. `or(prmt(a,0,0x4410), prmt(b,0,0x1044), 16))` -> `prmt(a,b,0x5410)`. It would be applicable to `prmt` itself, `or`, `build_vector`, `insert_vector_elt`, etc.

https://github.com/llvm/llvm-project/pull/116675


More information about the llvm-commits mailing list