[llvm] [SandboxIR] Add debug checker to compare IR before/after a revert (PR #115968)

Mon Nov 18 09:58:53 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/8371

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1096/1347] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FSUniqueIDTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1097/1347] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/IntrinsicInstTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1098/1347] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ExtensibleRTTITest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1099/1347] Building CXX object unittests/Option/CMakeFiles/OptionTests.dir/OptionParsingTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1100/1347] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o
FAILED: unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-uxuubj3_/unittests/SandboxIR -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-uxuubj3_/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googletest/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-suggest-override -MD -MT unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o -MF unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o.d -o unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:31: error: expected ';' after expression
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:14: error: no member named 'IRSnapshotChecker' in namespace 'llvm::sandboxir'
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |   ~~~~~~~~~~~^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:32: error: use of undeclared identifier 'Checker'
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1860:3: error: use of undeclared identifier 'Checker'
 1860 |   Checker.save();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1861:3: error: use of undeclared identifier 'Checker'
 1861 |   Checker.expectNoDiff();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:31: error: expected ';' after expression
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:14: error: no member named 'IRSnapshotChecker' in namespace 'llvm::sandboxir'
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |   ~~~~~~~~~~~^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:32: error: use of undeclared identifier 'Checker'
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1881:3: error: use of undeclared identifier 'Checker'
 1881 |   Checker.save();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1883:16: error: use of undeclared identifier 'Checker'
 1883 |   EXPECT_DEATH(Checker.expectNoDiff(), "Found IR difference");
      |                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1902:31: error: expected ';' after expression
 1902 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;
Step 7 (check) failure: check (failure)
...
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1096/1347] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FSUniqueIDTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1097/1347] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/IntrinsicInstTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1098/1347] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ExtensibleRTTITest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1099/1347] Building CXX object unittests/Option/CMakeFiles/OptionTests.dir/OptionParsingTest.cpp.o
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
[1100/1347] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o
FAILED: unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-uxuubj3_/unittests/SandboxIR -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR -I/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-uxuubj3_/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googletest/include -I/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffat-lto-objects -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fvisibility=default  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wno-suggest-override -MD -MT unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o -MF unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o.d -o unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o -c /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp
clang++: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:31: error: expected ';' after expression
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:14: error: no member named 'IRSnapshotChecker' in namespace 'llvm::sandboxir'
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |   ~~~~~~~~~~~^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1859:32: error: use of undeclared identifier 'Checker'
 1859 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1860:3: error: use of undeclared identifier 'Checker'
 1860 |   Checker.save();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1861:3: error: use of undeclared identifier 'Checker'
 1861 |   Checker.expectNoDiff();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:31: error: expected ';' after expression
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:14: error: no member named 'IRSnapshotChecker' in namespace 'llvm::sandboxir'
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |   ~~~~~~~~~~~^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1880:32: error: use of undeclared identifier 'Checker'
 1880 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1881:3: error: use of undeclared identifier 'Checker'
 1881 |   Checker.save();
      |   ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1883:16: error: use of undeclared identifier 'Checker'
 1883 |   EXPECT_DEATH(Checker.expectNoDiff(), "Found IR difference");
      |                ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/unittests/SandboxIR/TrackerTest.cpp:1902:31: error: expected ';' after expression
 1902 |   sandboxir::IRSnapshotChecker Checker(Ctx);
      |                               ^
      |                               ;

```

</details>

https://github.com/llvm/llvm-project/pull/115968