[llvm] [BOLT] Fix for bughunter.sh in offline mode (PR #116649)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 08:28:14 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-bolt
Author: Paschalis Mpeis (paschalis-mpeis)
<details>
<summary>Changes</summary>
In offline mode, the script sets 'PASS' variable and does not use it.
Surrounding code suggests using 'FAIL' variable instead.
---
Full diff: https://github.com/llvm/llvm-project/pull/116649.diff
1 Files Affected:
- (modified) bolt/utils/bughunter.sh (+2-2)
``````````diff
diff --git a/bolt/utils/bughunter.sh b/bolt/utils/bughunter.sh
index 49831cddfdbdd1..c5dddc41fb41fe 100755
--- a/bolt/utils/bughunter.sh
+++ b/bolt/utils/bughunter.sh
@@ -131,7 +131,7 @@ if [[ $FAIL -eq "0" ]]; then
fi
else
echo "Did it pass? Type the return code [0 = pass, 1 = fail]"
- read -n1 PASS
+ read -n1 FAIL
fi
if [[ $FAIL -eq "0" ]] ; then
echo " Warning: optimized binary passes."
@@ -205,7 +205,7 @@ while [[ "$CONTINUE" -ne "0" ]] ; do
echo " OPTIMIZED_BINARY failure=$FAIL"
else
echo "Did it pass? Type the return code [0 = pass, 1 = fail]"
- read -n1 PASS
+ read -n1 FAIL
fi
else
FAIL=1
``````````
</details>
https://github.com/llvm/llvm-project/pull/116649
More information about the llvm-commits
mailing list