[llvm] [BOLT] Fix for bughunter.sh in offline mode (PR #116649)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 08:27:27 PST 2024


https://github.com/paschalis-mpeis created https://github.com/llvm/llvm-project/pull/116649

In offline mode, the script sets 'PASS' variable and does not use it.
Surrounding code suggests using 'FAIL' variable instead.

>From fd4c4a9a4601911b2566b109551f80e618fa008b Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
Date: Mon, 18 Nov 2024 16:18:43 +0000
Subject: [PATCH] [BOLT] Fix for bughunter.sh in offline mode

In offline mode, the script sets 'PASS' variable and does not use it.
Surrounding code suggests using 'FAIL' variable instead.
---
 bolt/utils/bughunter.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bolt/utils/bughunter.sh b/bolt/utils/bughunter.sh
index 49831cddfdbdd1..c5dddc41fb41fe 100755
--- a/bolt/utils/bughunter.sh
+++ b/bolt/utils/bughunter.sh
@@ -131,7 +131,7 @@ if [[ $FAIL -eq "0" ]]; then
         fi
     else
         echo "Did it pass? Type the return code [0 = pass, 1 = fail]"
-        read -n1 PASS
+        read -n1 FAIL
     fi
     if [[ $FAIL -eq "0" ]] ; then
         echo "  Warning: optimized binary passes."
@@ -205,7 +205,7 @@ while [[ "$CONTINUE" -ne "0" ]] ; do
             echo "  OPTIMIZED_BINARY failure=$FAIL"
         else
             echo "Did it pass? Type the return code [0 = pass, 1 = fail]"
-            read -n1 PASS
+            read -n1 FAIL
         fi
     else
         FAIL=1



More information about the llvm-commits mailing list