[llvm] [X86] Fix position of immediate argument in AVX512 VPCMP comparisons (PR #116646)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 08:16:26 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 52361d0368b79841be12156bf03cf8c1851e5df7 4b75fa220027c169697d1fb7a7070dc2433a034a --extensions cpp -- llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp llvm/lib/Target/X86/MCTargetDesc/X86EncodingOptimization.cpp llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
index b67c573e21..602cd3150b 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
@@ -318,18 +318,30 @@ bool X86ATTInstPrinter::printVecCompareInstr(const MCInst *MI,
case X86::VPCMPWZ128rmik: case X86::VPCMPWZ128rrik:
case X86::VPCMPWZ256rmik: case X86::VPCMPWZ256rrik:
case X86::VPCMPWZrmik: case X86::VPCMPWZrrik:
- case X86::VPCMPDZ128rmbi: case X86::VPCMPDZ128rmbik:
- case X86::VPCMPDZ256rmbi: case X86::VPCMPDZ256rmbik:
- case X86::VPCMPDZrmbi: case X86::VPCMPDZrmbik:
- case X86::VPCMPQZ128rmbi: case X86::VPCMPQZ128rmbik:
- case X86::VPCMPQZ256rmbi: case X86::VPCMPQZ256rmbik:
- case X86::VPCMPQZrmbi: case X86::VPCMPQZrmbik:
- case X86::VPCMPUDZ128rmbi: case X86::VPCMPUDZ128rmbik:
- case X86::VPCMPUDZ256rmbi: case X86::VPCMPUDZ256rmbik:
- case X86::VPCMPUDZrmbi: case X86::VPCMPUDZrmbik:
- case X86::VPCMPUQZ128rmbi: case X86::VPCMPUQZ128rmbik:
- case X86::VPCMPUQZ256rmbi: case X86::VPCMPUQZ256rmbik:
- case X86::VPCMPUQZrmbi: case X86::VPCMPUQZrmbik:
+ case X86::VPCMPDZ128rmbi:
+ case X86::VPCMPDZ128rmbik:
+ case X86::VPCMPDZ256rmbi:
+ case X86::VPCMPDZ256rmbik:
+ case X86::VPCMPDZrmbi:
+ case X86::VPCMPDZrmbik:
+ case X86::VPCMPQZ128rmbi:
+ case X86::VPCMPQZ128rmbik:
+ case X86::VPCMPQZ256rmbi:
+ case X86::VPCMPQZ256rmbik:
+ case X86::VPCMPQZrmbi:
+ case X86::VPCMPQZrmbik:
+ case X86::VPCMPUDZ128rmbi:
+ case X86::VPCMPUDZ128rmbik:
+ case X86::VPCMPUDZ256rmbi:
+ case X86::VPCMPUDZ256rmbik:
+ case X86::VPCMPUDZrmbi:
+ case X86::VPCMPUDZrmbik:
+ case X86::VPCMPUQZ128rmbi:
+ case X86::VPCMPUQZ128rmbik:
+ case X86::VPCMPUQZ256rmbi:
+ case X86::VPCMPUQZ256rmbik:
+ case X86::VPCMPUQZrmbi:
+ case X86::VPCMPUQZrmbik:
if ((Imm >= 0 && Imm <= 2) || (Imm >= 4 && Imm <= 6)) {
OS << '\t';
printVPCMPMnemonic(MI, OS);
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
index fafcc737ff..3dc5b728c4 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
@@ -168,9 +168,12 @@ void X86InstPrinterCommon::printVPCMPMnemonic(const MCInst *MI,
case X86::VPCMPDZ128rmik: case X86::VPCMPDZ128rrik:
case X86::VPCMPDZ256rmik: case X86::VPCMPDZ256rrik:
case X86::VPCMPDZrmik: case X86::VPCMPDZrrik:
- case X86::VPCMPDZ128rmbi: case X86::VPCMPDZ128rmbik:
- case X86::VPCMPDZ256rmbi: case X86::VPCMPDZ256rmbik:
- case X86::VPCMPDZrmbi: case X86::VPCMPDZrmbik:
+ case X86::VPCMPDZ128rmbi:
+ case X86::VPCMPDZ128rmbik:
+ case X86::VPCMPDZ256rmbi:
+ case X86::VPCMPDZ256rmbik:
+ case X86::VPCMPDZrmbi:
+ case X86::VPCMPDZrmbik:
OS << "d\t";
break;
case X86::VPCMPQZ128rmi: case X86::VPCMPQZ128rri:
@@ -179,9 +182,12 @@ void X86InstPrinterCommon::printVPCMPMnemonic(const MCInst *MI,
case X86::VPCMPQZ128rmik: case X86::VPCMPQZ128rrik:
case X86::VPCMPQZ256rmik: case X86::VPCMPQZ256rrik:
case X86::VPCMPQZrmik: case X86::VPCMPQZrrik:
- case X86::VPCMPQZ128rmbi: case X86::VPCMPQZ128rmbik:
- case X86::VPCMPQZ256rmbi: case X86::VPCMPQZ256rmbik:
- case X86::VPCMPQZrmbi: case X86::VPCMPQZrmbik:
+ case X86::VPCMPQZ128rmbi:
+ case X86::VPCMPQZ128rmbik:
+ case X86::VPCMPQZ256rmbi:
+ case X86::VPCMPQZ256rmbik:
+ case X86::VPCMPQZrmbi:
+ case X86::VPCMPQZrmbik:
OS << "q\t";
break;
case X86::VPCMPUBZ128rmi: case X86::VPCMPUBZ128rri:
@@ -198,9 +204,12 @@ void X86InstPrinterCommon::printVPCMPMnemonic(const MCInst *MI,
case X86::VPCMPUDZ128rmik: case X86::VPCMPUDZ128rrik:
case X86::VPCMPUDZ256rmik: case X86::VPCMPUDZ256rrik:
case X86::VPCMPUDZrmik: case X86::VPCMPUDZrrik:
- case X86::VPCMPUDZ128rmbi: case X86::VPCMPUDZ128rmbik:
- case X86::VPCMPUDZ256rmbi: case X86::VPCMPUDZ256rmbik:
- case X86::VPCMPUDZrmbi: case X86::VPCMPUDZrmbik:
+ case X86::VPCMPUDZ128rmbi:
+ case X86::VPCMPUDZ128rmbik:
+ case X86::VPCMPUDZ256rmbi:
+ case X86::VPCMPUDZ256rmbik:
+ case X86::VPCMPUDZrmbi:
+ case X86::VPCMPUDZrmbik:
OS << "ud\t";
break;
case X86::VPCMPUQZ128rmi: case X86::VPCMPUQZ128rri:
@@ -209,9 +218,12 @@ void X86InstPrinterCommon::printVPCMPMnemonic(const MCInst *MI,
case X86::VPCMPUQZ128rmik: case X86::VPCMPUQZ128rrik:
case X86::VPCMPUQZ256rmik: case X86::VPCMPUQZ256rrik:
case X86::VPCMPUQZrmik: case X86::VPCMPUQZrrik:
- case X86::VPCMPUQZ128rmbi: case X86::VPCMPUQZ128rmbik:
- case X86::VPCMPUQZ256rmbi: case X86::VPCMPUQZ256rmbik:
- case X86::VPCMPUQZrmbi: case X86::VPCMPUQZrmbik:
+ case X86::VPCMPUQZ128rmbi:
+ case X86::VPCMPUQZ128rmbik:
+ case X86::VPCMPUQZ256rmbi:
+ case X86::VPCMPUQZ256rmbik:
+ case X86::VPCMPUQZrmbi:
+ case X86::VPCMPUQZrmbik:
OS << "uq\t";
break;
case X86::VPCMPUWZ128rmi: case X86::VPCMPUWZ128rri:
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
index 680092679c..2ce6af506f 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
@@ -295,18 +295,30 @@ bool X86IntelInstPrinter::printVecCompareInstr(const MCInst *MI, raw_ostream &OS
case X86::VPCMPWZ128rmik: case X86::VPCMPWZ128rrik:
case X86::VPCMPWZ256rmik: case X86::VPCMPWZ256rrik:
case X86::VPCMPWZrmik: case X86::VPCMPWZrrik:
- case X86::VPCMPDZ128rmbi: case X86::VPCMPDZ128rmbik:
- case X86::VPCMPDZ256rmbi: case X86::VPCMPDZ256rmbik:
- case X86::VPCMPDZrmbi: case X86::VPCMPDZrmbik:
- case X86::VPCMPQZ128rmbi: case X86::VPCMPQZ128rmbik:
- case X86::VPCMPQZ256rmbi: case X86::VPCMPQZ256rmbik:
- case X86::VPCMPQZrmbi: case X86::VPCMPQZrmbik:
- case X86::VPCMPUDZ128rmbi: case X86::VPCMPUDZ128rmbik:
- case X86::VPCMPUDZ256rmbi: case X86::VPCMPUDZ256rmbik:
- case X86::VPCMPUDZrmbi: case X86::VPCMPUDZrmbik:
- case X86::VPCMPUQZ128rmbi: case X86::VPCMPUQZ128rmbik:
- case X86::VPCMPUQZ256rmbi: case X86::VPCMPUQZ256rmbik:
- case X86::VPCMPUQZrmbi: case X86::VPCMPUQZrmbik:
+ case X86::VPCMPDZ128rmbi:
+ case X86::VPCMPDZ128rmbik:
+ case X86::VPCMPDZ256rmbi:
+ case X86::VPCMPDZ256rmbik:
+ case X86::VPCMPDZrmbi:
+ case X86::VPCMPDZrmbik:
+ case X86::VPCMPQZ128rmbi:
+ case X86::VPCMPQZ128rmbik:
+ case X86::VPCMPQZ256rmbi:
+ case X86::VPCMPQZ256rmbik:
+ case X86::VPCMPQZrmbi:
+ case X86::VPCMPQZrmbik:
+ case X86::VPCMPUDZ128rmbi:
+ case X86::VPCMPUDZ128rmbik:
+ case X86::VPCMPUDZ256rmbi:
+ case X86::VPCMPUDZ256rmbik:
+ case X86::VPCMPUDZrmbi:
+ case X86::VPCMPUDZrmbik:
+ case X86::VPCMPUQZ128rmbi:
+ case X86::VPCMPUQZ128rmbik:
+ case X86::VPCMPUQZ256rmbi:
+ case X86::VPCMPUQZ256rmbik:
+ case X86::VPCMPUQZrmbi:
+ case X86::VPCMPUQZrmbik:
if ((Imm >= 0 && Imm <= 2) || (Imm >= 4 && Imm <= 6)) {
OS << '\t';
printVPCMPMnemonic(MI, OS);
``````````
</details>
https://github.com/llvm/llvm-project/pull/116646
More information about the llvm-commits
mailing list