[llvm] [SPIR-V] Fixup storage class for global private (PR #116636)

Steven Perron via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 07:56:58 PST 2024


Nathan =?utf-8?q?Gau=C3=ABr?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/116636 at github.com>


================
@@ -3337,11 +3343,8 @@ bool SPIRVInstructionSelector::selectGlobalValue(
   if (HasInit && !Init)
     return true;
 
-  unsigned AddrSpace = GV->getAddressSpace();
-  SPIRV::StorageClass::StorageClass Storage =
-      addressSpaceToStorageClass(AddrSpace, STI);
   bool HasLnkTy = GV->getLinkage() != GlobalValue::InternalLinkage &&
-                  Storage != SPIRV::StorageClass::Function;
+                  StorageClass != SPIRV::StorageClass::Function;
----------------
s-perron wrote:

You were too fast. I changed it to Private after. My mistake.

https://github.com/llvm/llvm-project/pull/116636


More information about the llvm-commits mailing list