[llvm] [SPIR-V] Fixup storage class for global private (PR #116636)

[Steven Perron via llvm-commits]

================
@@ -3337,11 +3343,8 @@ bool SPIRVInstructionSelector::selectGlobalValue(
   if (HasInit && !Init)
     return true;
 
-  unsigned AddrSpace = GV->getAddressSpace();
-  SPIRV::StorageClass::StorageClass Storage =
-      addressSpaceToStorageClass(AddrSpace, STI);
   bool HasLnkTy = GV->getLinkage() != GlobalValue::InternalLinkage &&
-                  Storage != SPIRV::StorageClass::Function;
+                  StorageClass != SPIRV::StorageClass::Function;
----------------
s-perron wrote:

Can `StorageClass` be `Function` anymore? You change it to `Static` at line 3272, right?
```suggestion
                  StorageClass != SPIRV::StorageClass::Static;
```

https://github.com/llvm/llvm-project/pull/116636