[llvm] [RISCV] Correct the precedence in isVRegClass (PR #116579)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 17 23:04:51 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-risc-v
Author: Brandon Wu (4vtomat)
<details>
<summary>Changes</summary>
Right shift has higher precedence than bitwise and, so it should be
parentheses around & operator. This case works as expected because
IsVRegClassShift is 0, other cases will fail.
---
Full diff: https://github.com/llvm/llvm-project/pull/116579.diff
1 Files Affected:
- (modified) llvm/lib/Target/RISCV/RISCVRegisterInfo.h (+1-1)
``````````diff
diff --git a/llvm/lib/Target/RISCV/RISCVRegisterInfo.h b/llvm/lib/Target/RISCV/RISCVRegisterInfo.h
index 6ddb1eb9c14d5e..3ab79694e175c8 100644
--- a/llvm/lib/Target/RISCV/RISCVRegisterInfo.h
+++ b/llvm/lib/Target/RISCV/RISCVRegisterInfo.h
@@ -39,7 +39,7 @@ enum {
/// \returns the IsVRegClass for the register class.
static inline bool isVRegClass(uint64_t TSFlags) {
- return TSFlags & IsVRegClassShiftMask >> IsVRegClassShift;
+ return (TSFlags & IsVRegClassShiftMask) >> IsVRegClassShift;
}
/// \returns the LMUL for the register class.
``````````
</details>
https://github.com/llvm/llvm-project/pull/116579
More information about the llvm-commits
mailing list