[llvm] [Tablegen] Add more comments for result numbers to DAGISelEmitter.cpp (PR #116533)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 02:11:13 PST 2024


================
@@ -851,24 +856,32 @@ unsigned MatcherTableEmitter::EmitMatcher(const Matcher *N,
       break;
     }
     if (Reg) {
-      OS << getQualifiedName(Reg->TheDef) << ",\n";
+      OS << getQualifiedName(Reg->TheDef);
     } else {
       OS << "0 ";
       if (!OmitComments)
         OS << "/*zero_reg*/";
-      OS << ",\n";
     }
+
+    OS << ',';
+    if (!OmitComments)
+      OS << " // #" << Matcher->getResultNo();
+    OS << '\n';
     return OpBytes + 1;
   }
 
   case Matcher::EmitConvertToTarget: {
-    unsigned Slot = cast<EmitConvertToTargetMatcher>(N)->getSlot();
-    if (Slot < 8) {
-      OS << "OPC_EmitConvertToTarget" << Slot << ",\n";
-      return 1;
-    }
-    OS << "OPC_EmitConvertToTarget, " << Slot << ",\n";
-    return 2;
+    const EmitConvertToTargetMatcher *CTTM =
+        cast<EmitConvertToTargetMatcher>(N);
----------------
s-barannikov wrote:

Use `const auto *` with cast?

https://github.com/llvm/llvm-project/pull/116533


More information about the llvm-commits mailing list