[llvm] [Support] Add clang tooling generated explicit visibility macros (PR #113097)

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 11:06:54 PST 2024


================
@@ -103,12 +103,12 @@ namespace detail {
 template <typename Period> struct unit { static const char value[]; };
 template <typename Period> const char unit<Period>::value[] = "";
 
-template <> struct unit<std::ratio<3600>> { static const char value[]; };
-template <> struct unit<std::ratio<60>> { static const char value[]; };
-template <> struct unit<std::ratio<1>> { static const char value[]; };
-template <> struct unit<std::milli> { static const char value[]; };
-template <> struct unit<std::micro> { static const char value[]; };
-template <> struct unit<std::nano> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::ratio<3600>> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::ratio<60>> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::ratio<1>> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::milli> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::micro> { static const char value[]; };
+template <> struct LLVM_ABI unit<std::nano> { static const char value[]; };
 } // namespace detail
----------------
compnerd wrote:

Should these be/are they `extern template`'ed?

https://github.com/llvm/llvm-project/pull/113097


More information about the llvm-commits mailing list