[llvm] Overhaul the TargetMachine and LLVMTargetMachine Classes (PR #111234)

Thu Nov 14 13:48:25 PST 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `llvm,offload` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/7655

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
751.291 [2250/16/1885] Building CXX object lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCRegisterInfo.cpp.o
751.406 [2249/16/1886] Building CXX object lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o
751.417 [2248/16/1887] Linking CXX static library lib/libLLVMLineEditor.a
751.450 [2247/16/1888] Building CXX object lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCISelLowering.cpp.o
751.473 [2246/16/1889] Building CXX object lib/SandboxIR/CMakeFiles/LLVMSandboxIR.dir/Use.cpp.o
752.889 [2245/16/1890] Building CXX object lib/SandboxIR/CMakeFiles/LLVMSandboxIR.dir/Region.cpp.o
753.129 [2244/16/1891] Building CXX object lib/SandboxIR/CMakeFiles/LLVMSandboxIR.dir/Value.cpp.o
753.688 [2243/16/1892] Building CXX object lib/AsmParser/CMakeFiles/LLVMAsmParser.dir/LLLexer.cpp.o
753.871 [2242/16/1893] Building CXX object lib/SandboxIR/CMakeFiles/LLVMSandboxIR.dir/Tracker.cpp.o
754.463 [2241/16/1894] Building CXX object lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCTargetMachine.cpp.o
FAILED: lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCTargetMachine.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Target/ARC -I/buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC -Iinclude -I/buildbot/worker/arc-folder/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCTargetMachine.cpp.o -MF lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCTargetMachine.cpp.o.d -o lib/Target/ARC/CMakeFiles/LLVMARCCodeGen.dir/ARCTargetMachine.cpp.o -c /buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.cpp
/buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.cpp: In constructor 'llvm::ARCTargetMachine::ARCTargetMachine(const llvm::Target&, const llvm::Triple&, llvm::StringRef, llvm::StringRef, const llvm::TargetOptions&, std::optional<llvm::Reloc::Model>, std::optional<llvm::CodeModel::Model>, llvm::CodeGenOptLevel, bool)':
/buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.cpp:36:7: error: class 'llvm::ARCTargetMachine' does not have any field named 'CodeGenCommonTMImpl'
   36 |     : CodeGenCommonTMImpl(T,
      |       ^~~~~~~~~~~~~~~~~~~
/buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.cpp:42:61: error: no matching function for call to 'llvm::CodeGenTargetMachineImpl::CodeGenTargetMachineImpl()'
   42 |       Subtarget(TT, std::string(CPU), std::string(FS), *this) {
      |                                                             ^
In file included from /buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.h:17,
                 from /buildbot/worker/arc-folder/llvm-project/llvm/lib/Target/ARC/ARCTargetMachine.cpp:12:
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/CodeGen/CodeGenTargetMachineImpl.h:25:3: note: candidate: 'llvm::CodeGenTargetMachineImpl::CodeGenTargetMachineImpl(const llvm::Target&, llvm::StringRef, const llvm::Triple&, llvm::StringRef, llvm::StringRef, const llvm::TargetOptions&, llvm::Reloc::Model, llvm::CodeModel::Model, llvm::CodeGenOptLevel)'
   25 |   CodeGenTargetMachineImpl(const Target &T, StringRef DataLayoutString,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/buildbot/worker/arc-folder/llvm-project/llvm/include/llvm/CodeGen/CodeGenTargetMachineImpl.h:25:3: note:   candidate expects 9 arguments, 0 provided
756.032 [2241/15/1895] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/GCOV.cpp.o
757.157 [2241/14/1896] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/PGOCtxProfReader.cpp.o
757.332 [2241/13/1897] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/PGOCtxProfWriter.cpp.o
757.504 [2241/12/1898] Building CXX object lib/AsmParser/CMakeFiles/LLVMAsmParser.dir/Parser.cpp.o
757.803 [2241/11/1899] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfCorrelator.cpp.o
758.149 [2241/10/1900] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/MemProf.cpp.o
759.781 [2241/9/1901] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ItaniumManglingCanonicalizer.cpp.o
759.924 [2241/8/1902] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/ProfileSummaryBuilder.cpp.o
760.213 [2241/7/1903] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProf.cpp.o
760.952 [2241/6/1904] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProf.cpp.o
762.248 [2241/5/1905] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/MemProfReader.cpp.o
762.467 [2241/4/1906] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfWriter.cpp.o
763.208 [2241/3/1907] Building CXX object lib/ProfileData/CMakeFiles/LLVMProfileData.dir/InstrProfReader.cpp.o
767.704 [2241/2/1908] Building CXX object lib/AsmParser/CMakeFiles/LLVMAsmParser.dir/LLParser.cpp.o
780.739 [2241/1/1909] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ISelLowering.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/111234