[llvm] [AMDGPU] Fix module split's assumption on kernels (PR #116280)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 14 13:06:26 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 7b7ae72b5863c4090bf06d1f10cd676823e02fb1 b70e6fc2eb988a4b0a56883f94cea45175bdb4b4 --extensions cpp -- llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp b/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
index 1942c70427..aa5da2ce7c 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
@@ -157,8 +157,8 @@ static auto formatRatioOf(CostType Num, CostType Dem) {
/// Non-copyable functions cannot be cloned into multiple partitions, and only
/// one copy of the function can be present across all partitions.
///
-/// Kernel functions and external functions fall into this category. If we were
-/// to clone them, we would end up with multiple symbol definitions and a very
+/// Kernel functions and external functions fall into this category. If we were
+/// to clone them, we would end up with multiple symbol definitions and a very
/// unhappy linker.
static bool isNonCopyable(const Function &F) {
return AMDGPU::isEntryFunctionCC(F.getCallingConv()) ||
``````````
</details>
https://github.com/llvm/llvm-project/pull/116280
More information about the llvm-commits
mailing list