[llvm] [memprof] Use ArrayRef instead of std::vector<LinearFrameId> (NFC) (PR #116279)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 14 12:56:31 PST 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/116279

LLVM Programmer's Manual prefers ArrayRef over actual sequential
container types for read accesses.


>From d93e7cd59265df292434cdbf8466114dc447ca6c Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 14 Nov 2024 12:41:26 -0800
Subject: [PATCH] [memprof] Use ArrayRef instead of std::vector<LinearFrameId>
 (NFC)

LLVM Programmer's Manual prefers ArrayRef over actual sequential
container types for read accesses.
---
 llvm/include/llvm/ProfileData/MemProf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/include/llvm/ProfileData/MemProf.h b/llvm/include/llvm/ProfileData/MemProf.h
index ff05bb7da2f799..bfd91407769bb3 100644
--- a/llvm/include/llvm/ProfileData/MemProf.h
+++ b/llvm/include/llvm/ProfileData/MemProf.h
@@ -1134,7 +1134,7 @@ class CallStackRadixTreeBuilder {
              const llvm::DenseMap<FrameId, LinearFrameId> &MemProfFrameIndexes,
              llvm::DenseMap<FrameId, FrameStat> &FrameHistogram);
 
-  const std::vector<LinearFrameId> &getRadixArray() const { return RadixArray; }
+  ArrayRef<LinearFrameId> getRadixArray() const { return RadixArray; }
 
   llvm::DenseMap<CallStackId, LinearCallStackId> takeCallStackPos() {
     return std::move(CallStackPos);



More information about the llvm-commits mailing list