[llvm] [Analysis] Remove global state from `PluginInline{Advisor,Order}Analysis`. (PR #114615)

[Arthur Eubanks via llvm-commits]

aeubanks wrote:

thanks for pointing out that specific piece of code, I can't come up with a better way of doing that so this PR lgtm.

please update the comments [here](https://github.com/llvm/llvm-project/blob/6f5a145aebee4a925da28d409d69ec7f4ea19f40/llvm/include/llvm/IR/PassManager.h#L460) in this PR, removing the part where it says there's no way to query if an analysis is registered

I'd also request that the comments [here](https://github.com/llvm/llvm-project/blob/5005f8d2486d6eec7b2b8ae04f49e8a87ebf4bf6/llvm/include/llvm/Analysis/InlineAdvisor.h#L241) be updated to use `PassBuilder::registerAnalysisRegistrationCallback` instead of adding a pass that registers the analysis (in a separate PR)

https://github.com/llvm/llvm-project/pull/114615