[llvm] [SHT_LLVM_BB_ADDR_MAP] Add an option to skip emitting bb entries (PR #114447)
Lei Wang via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 12 20:43:59 PST 2024
wlei-llvm wrote:
Thank you for the code review! @rlavaee
> Sorry for the late review. `NoBBEntries` makes the code a bit unreadable with double negatives. Though it makes backward compatibility easier as we don't need to add a new version. I imagine `HasBBEntries` would look much better throughout the code. I don't have a strong opinion though. If you want to keep it this way, I suggest you change it to `OmitBBEntries`.
I thought "BBAddrMap" should imply "HasBBEntries" by default, was to avoid the situation that "people want to use BBAddrMap, but have to explicitly code `HasBBEntries`. I also tried it today, we would need to set the value to true for more than one place(ELFEmitter/Elf2yaml), and also as you said, needs to bump the version for backwards support(that means almost all the related tests need to update). I feel it's more complicated.
If this makes sense, I will follow your suggestion to use `OmitBBEntries`.
https://github.com/llvm/llvm-project/pull/114447
More information about the llvm-commits
mailing list