[llvm] eea8b44 - [GVN] Handle empty attrs in Expression == (#115761)

[via llvm-commits]

Author: macurtis-amd
Date: 2024-11-12T09:08:06-06:00
New Revision: eea8b44aaa3464f52dea1d56ca47e0519b08fd36

URL: https://github.com/llvm/llvm-project/commit/eea8b44aaa3464f52dea1d56ca47e0519b08fd36
DIFF: https://github.com/llvm/llvm-project/commit/eea8b44aaa3464f52dea1d56ca47e0519b08fd36.diff

LOG: [GVN] Handle empty attrs in Expression == (#115761)

Added: 
    llvm/test/Transforms/GVN/intersect-empty-attr.ll

Modified: 
    llvm/lib/Transforms/Scalar/GVN.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp
index e27f5a08c85a97..a3df7a0a39e6b2 100644
--- a/llvm/lib/Transforms/Scalar/GVN.cpp
+++ b/llvm/lib/Transforms/Scalar/GVN.cpp
@@ -156,7 +156,7 @@ struct llvm::GVNPass::Expression {
       return false;
     if (varargs != other.varargs)
       return false;
-    if (!attrs.isEmpty() && !other.attrs.isEmpty() &&
+    if ((!attrs.isEmpty() || !other.attrs.isEmpty()) &&
         !attrs.intersectWith(type->getContext(), other.attrs).has_value())
       return false;
     return true;

diff  --git a/llvm/test/Transforms/GVN/intersect-empty-attr.ll b/llvm/test/Transforms/GVN/intersect-empty-attr.ll
new file mode 100644
index 00000000000000..a2d719e4187581
--- /dev/null
+++ b/llvm/test/Transforms/GVN/intersect-empty-attr.ll
@@ -0,0 +1,21 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -S -passes=gvn < %s | FileCheck %s
+
+declare i32 @bar() #0
+
+define i32 @foo() {
+; CHECK-LABEL: define i32 @foo() {
+; CHECK-NEXT:  [[ENTRY:.*:]]
+; CHECK-NEXT:    [[TMP0:%.*]] = tail call i32 @bar() #[[ATTR1:[0-9]+]]
+; CHECK-NEXT:    [[TMP1:%.*]] = tail call i32 @bar()
+; CHECK-NEXT:    ret i32 1
+;
+entry:
+  %0 = tail call i32 @bar() #1
+  %1 = tail call i32 @bar()
+  ret i32 1
+}
+
+
+attributes #0 = { memory(none) }
+attributes #1 = { "llvm.assume"="ompx_no_call_asm" }