[llvm] [llvm-objdump] Add preliminary support for decoding binary files (PR #115667)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 12 03:01:30 PST 2024
https://github.com/jh7370 commented:
We should aim for this new binary option (not to be confused with the triple option) to be command-line compatible with the equivalent GNU option, i.e. to have the same name. This is similar to our existing option behaviour. NB: for textual output, it doesn't need to be byte-for-byte identical.
That being said, internally, I'd like to reduce the ambiguity caused by the term "binary" since any file on disk is a binary file, just usually with some specific structure (i.e. ELF/COFF etc). This is particularly an issue because we already have a `Binary` class, which reflects this relationship. Could we refer to it as `RawBinary` everywhere in file/variable/function names etc as appropriate?
Is this intended to have a functional impact, as there is no testing included.
https://github.com/llvm/llvm-project/pull/115667
More information about the llvm-commits
mailing list