[llvm] [SHT_LLVM_BB_ADDR_MAP] Add an option to skip emitting bb entries (PR #114447)

Rahman Lavaee via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 22:09:19 PST 2024


rlavaee wrote:

Sorry for the late review.  `NoBBEntries` makes the code a bit unreadable with double negatives. Though it makes backward compatibility easier as we don't need to add a new version. I imagine `HasBBEntries` would look much better throughout the code. I don't have a strong opinion though. If you want to keep it this way, I suggest you change it to `OmitBBEntries`.

https://github.com/llvm/llvm-project/pull/114447


More information about the llvm-commits mailing list