[llvm] [InstCombine] Transform (fcmp + fadd + sel) into (fcmp + sel + fadd) (PR #106492)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ve-ninja` running on `hpce-ve-main` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/12/builds/9364

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/ve-linux.py ...' (failure)
...
[672/673] Running the LLVM regression tests
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
An error occurred retrieving the git revision: Command '['git', '-C', '/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm', 'rev-parse', 'HEAD']' returned non-zero exit status 129.
-- Testing: 56454 tests, 48 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.
FAIL: LLVM :: Transforms/InstCombine/fcmp-fadd-select.ll (42951 of 56454)
******************** TEST 'LLVM :: Transforms/InstCombine/fcmp-fadd-select.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/opt < /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll -passes=instcombine -S | /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/FileCheck /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll
+ /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/FileCheck /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll
+ /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/opt -passes=instcombine -S
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:62:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:29:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:29:99: note: with "SEL_NEW" equal to "%sel"
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:30:2: note: possible intended match here
 %add = fadd nnan nsz <2 x float> %sel, splat (float 1.000000e+00)
 ^
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:130:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:59:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.minnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:59:99: note: with "SEL_NEW" equal to "%sel"
 %sel = call nnan nsz <2 x float> @llvm.minnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:60:2: note: possible intended match here
 %add = fadd nnan nsz <2 x float> %sel, splat (float 1.000000e+00)
 ^
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:198:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:89:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
Step 8 (check-llvm) failure: check-llvm (failure)
...
[672/673] Running the LLVM regression tests
Unknown option: -C
usage: git [--version] [--help] [-c name=value]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]
An error occurred retrieving the git revision: Command '['git', '-C', '/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm', 'rev-parse', 'HEAD']' returned non-zero exit status 129.
-- Testing: 56454 tests, 48 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.
FAIL: LLVM :: Transforms/InstCombine/fcmp-fadd-select.ll (42951 of 56454)
******************** TEST 'LLVM :: Transforms/InstCombine/fcmp-fadd-select.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/opt < /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll -passes=instcombine -S | /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/FileCheck /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll
+ /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/FileCheck /scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll
+ /scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm/bin/opt -passes=instcombine -S
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:62:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:29:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:29:99: note: with "SEL_NEW" equal to "%sel"
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:30:2: note: possible intended match here
 %add = fadd nnan nsz <2 x float> %sel, splat (float 1.000000e+00)
 ^
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:130:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:59:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.minnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:59:99: note: with "SEL_NEW" equal to "%sel"
 %sel = call nnan nsz <2 x float> @llvm.minnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^
<stdin>:60:2: note: possible intended match here
 %add = fadd nnan nsz <2 x float> %sel, splat (float 1.000000e+00)
 ^
/scratch/buildbot/bothome/clang-ve-ninja/llvm-project/llvm/test/Transforms/InstCombine/fcmp-fadd-select.ll:198:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: [[ADD_NEW:%.*]] = fadd nnan nsz <2 x float> [[SEL_NEW]], <float 1.000000e+00, float 1.000000e+00>
              ^
<stdin>:89:99: note: scanning from here
 %sel = call nnan nsz <2 x float> @llvm.maxnum.v2f32(<2 x float> %in, <2 x float> zeroinitializer)
                                                                                                  ^

```

</details>

https://github.com/llvm/llvm-project/pull/106492